Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BUGFIX: User locale was used index data BUGFIX: missing Norwegian fulltext config FEATURE: store the text used to index stuff in fulltext (for diagnostics / in page search) FEATURE: re-index posts when locale changes (in bg job) FEATURE: allow reindexing by trucating post_search_data Note: I removed japanese specific config cause it requires custom pg config, happy to add it once our base docker config ships with it
- Loading branch information
1 parent
51ff644
commit 3c84876
Showing
8 changed files
with
134 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
class AddRawDataToSearch < ActiveRecord::Migration | ||
def change | ||
add_column :post_search_data, :raw_data, :text | ||
add_column :user_search_data, :raw_data, :text | ||
add_column :category_search_data, :raw_data, :text | ||
|
||
add_column :post_search_data, :locale, :string | ||
add_column :user_search_data, :locale, :text | ||
add_column :category_search_data, :locale, :text | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
require 'spec_helper' | ||
|
||
describe SearchObserver do | ||
|
||
def get_row(post_id) | ||
SqlBuilder.map_exec( | ||
OpenStruct, | ||
"select * from post_search_data where post_id = :post_id", | ||
post_id: post_id | ||
).first | ||
end | ||
|
||
it 'correctly indexes chinese' do | ||
SiteSetting.default_locale = 'zh_CN' | ||
data = "你好世界" | ||
data.split(" ").length.should == 1 | ||
|
||
SearchObserver.update_posts_index(99, "你好世界", "", nil) | ||
|
||
row = get_row(99) | ||
row.raw_data.split(' ').length.should == 2 | ||
end | ||
|
||
it 'correctly indexes a post' do | ||
data = "<a>This</a> is a test" | ||
|
||
SearchObserver.update_posts_index(99, data, "", nil) | ||
|
||
row = get_row(99) | ||
|
||
row.raw_data.should == "This is a test" | ||
row.locale.should == "en" | ||
|
||
SearchObserver.update_posts_index(99, "tester", "", nil) | ||
|
||
row = get_row(99) | ||
|
||
row.raw_data.should == "tester" | ||
end | ||
end |
3c84876
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️