FIX: don't break when posting invalid URIs

discourse · Apr 19, 2018 · 45850a0 · 45850a0 · discoursebot · Apr 19, 2018
1 parent 74b8125
commit 45850a0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/models/topic_link.rb b/app/models/topic_link.rb
@@ -118,7 +118,7 @@ def self.extract_from(post)
         .map do |u|
           uri = begin
             URI.parse(u.url)
-          rescue URI::InvalidURIError
+          rescue URI::Error
           end
 
           [u, uri]

diff --git a/spec/models/topic_link_spec.rb b/spec/models/topic_link_spec.rb
@@ -169,6 +169,14 @@ def test_uri
       end
     end
 
+    context "email address" do
+      it "does not extract a link" do
+        post = topic.posts.create(user: user, raw: "Valid email: foo@bar.com\n\nInvalid email: rfc822;name@domain.com")
+        TopicLink.extract_from(post)
+        expect(topic.topic_links).to be_blank
+      end
+    end
+
     context "mail link" do
       let(:post) { topic.posts.create(user: user, raw: "[email]bar@example.com[/email]") }