DEV: No need to use call to call these callbacks

This is safe because addNavigationBarItem decorates these callbacks, throwing away the context.
discourse · Nov 13, 2019 · 60e804a · 60e804a
1 parent 5ff84be
commit 60e804a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/assets/javascripts/discourse/models/nav-item.js.es6 b/app/assets/javascripts/discourse/models/nav-item.js.es6
@@ -164,14 +164,14 @@ NavItem.reopenClass({
 
     const extraItems = NavItem.extraNavItems.filter(item => {
       if (!item.customFilter) return true;
-      return item.customFilter.call(this, category, args);
+      return item.customFilter(category, args);
     });
 
     let forceActive = false;
 
     extraItems.forEach(item => {
       if (item.init) {
-        item.init.call(this, item, category, args);
+        item.init(item, category, args);
       }
 
       const before = item.before;
@@ -189,9 +189,9 @@ NavItem.reopenClass({
 
       if (!item.customHref) return;
 
-      item.set("href", item.customHref.call(this, category, args));
+      item.set("href", item.customHref(category, args));
 
-      if (item.forceActive && item.forceActive.call(this, category, args)) {
+      if (item.forceActive && item.forceActive(category, args)) {
         item.active = true;
         forceActive = true;
       } else {