Skip to content

Commit

Permalink
FIX: Notification menu broken on older browsers (#14019)
Browse files Browse the repository at this point in the history
replaceAll is not available in all versions of Chrome/Firefox/Edge
that we support, so we need to use replace instead
  • Loading branch information
martin-brennan committed Aug 11, 2021
1 parent 20a6bad commit 814aa64
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -33,7 +33,7 @@ export const DefaultNotificationItem = createWidget(
const lookup = this.site.get("notificationLookup");
const notificationName = lookup[notificationType];
if (notificationName) {
classNames.push(notificationName.replaceAll("_", "-"));
classNames.push(notificationName.replace(/_/g, "-"));
}
return classNames;
},
Expand Down

1 comment on commit 814aa64

@discoursebot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/notification-tab-keeps-loading-on-edge-for-android/199413/18

Please sign in to comment.