Skip to content

Commit

Permalink
UX: dashboard links to git commits list instead of git comparison
Browse files Browse the repository at this point in the history
Previously the link went to a comparison of the installed commit with
the tests-passed branch. This change will show the list of installed
commits.
  • Loading branch information
nlalonde committed Oct 17, 2019
1 parent d1b8635 commit 85140aa
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions app/assets/javascripts/admin/models/version-check.js.es6
Expand Up @@ -17,12 +17,10 @@ const VersionCheck = Discourse.Model.extend({
return missingVersionsCount === 1;
},

@computed("git_branch", "installed_sha")
gitLink(gitBranch, installedSHA) {
if (gitBranch && installedSHA) {
return `https://github.com/discourse/discourse/compare/${installedSHA}...${gitBranch}`;
} else if (installedSHA) {
return `https://github.com/discourse/discourse/tree/${installedSHA}`;
@computed("installed_sha")
gitLink(installedSHA) {
if (installedSHA) {
return `https://github.com/discourse/discourse/commits/${installedSHA}`;
}
},

Expand Down

1 comment on commit 85140aa

@discoursebot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/new-dashboard-link-to-commit-diff-is-odd/128358/5

Please sign in to comment.