Skip to content

Commit

Permalink
FIX: Onceoff job to recover missing post uploads.
Browse files Browse the repository at this point in the history
This fixes the regression due to 1f636c4
  • Loading branch information
tgxworld committed Sep 14, 2018
1 parent cb3be41 commit 8a17138
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 0 deletions.
22 changes: 22 additions & 0 deletions app/jobs/onceoff/recover_post_uploads.rb
@@ -0,0 +1,22 @@
require_dependency "upload_recovery"

module Jobs
class RecoverPostUploads < Jobs::Onceoff
MIN_PERIOD = 30
MAX_PERIOD = 120

def execute_onceoff(args)
UploadRecovery.new.recover(Post.where(
"baked_at >= ?",
grace_period.days.ago
))
end

def grace_period
SiteSetting.purge_deleted_uploads_grace_period_days.clamp(
MIN_PERIOD,
MAX_PERIOD
)
end
end
end
17 changes: 17 additions & 0 deletions spec/jobs/recover_post_uploads_spec.rb
@@ -0,0 +1,17 @@
require 'rails_helper'

RSpec.describe Jobs::RecoverPostUploads do
describe '#grace_period' do
it 'should restrict the grace period to the right range' do
SiteSetting.purge_deleted_uploads_grace_period_days =
described_class::MIN_PERIOD - 1

expect(described_class.new.grace_period).to eq(30)

SiteSetting.purge_deleted_uploads_grace_period_days =
described_class::MAX_PERIOD + 1

expect(described_class.new.grace_period).to eq(120)
end
end
end

1 comment on commit 8a17138

@discoursebot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.