Skip to content

Commit

Permalink
Improve theme/component delete modal warning
Browse files Browse the repository at this point in the history
  • Loading branch information
pmusaraj committed May 10, 2019
1 parent c093fa0 commit a859ddc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Expand Up @@ -263,7 +263,9 @@ export default Ember.Controller.extend({

destroy() {
return bootbox.confirm(
I18n.t("admin.customize.delete_confirm"),
I18n.t("admin.customize.delete_confirm", {
theme_name: this.get("model.name")
}),
I18n.t("no_value"),
I18n.t("yes_value"),
result => {
Expand Down
2 changes: 1 addition & 1 deletion config/locales/client.en.yml
Expand Up @@ -3360,7 +3360,7 @@ en:
new_style: "New Style"
install: "Install"
delete: "Delete"
delete_confirm: "Delete this theme?"
delete_confirm: 'Are you sure you want to delete "%{theme_name}"?'
color: "Color"
opacity: "Opacity"
copy: "Copy"
Expand Down

1 comment on commit a859ddc

@discoursebot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/deleting-a-theme-component-elicits-mildly-alarming-modal-text/117412/2

Please sign in to comment.