BUGFIX: anon cache was mucking with params

discourse · Jan 9, 2014 · adc9a58 · adc9a58
1 parent 1b8a32b
commit adc9a58
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/config/initializers/99-anon-cache.rb b/config/initializers/99-anon-cache.rb
@@ -6,9 +6,6 @@
             Rails.env.production?
           end
 
-# DISABLE to check if its killing the smoke test
-enabled = false
-
 if !ENV['DISCOURSE_DISABLE_ANON_CACHE'] && enabled
   # in an ideal world this is position 0, but mobile detection uses ... session and request and params
   Rails.configuration.middleware.insert_after ActionDispatch::ParamsParser, Middleware::AnonymousCache

diff --git a/lib/middleware/anonymous_cache.rb b/lib/middleware/anonymous_cache.rb
@@ -20,7 +20,9 @@ def is_mobile?
         @is_mobile ||=
           begin
             session = @env["rack.session"]
-            params = ActionDispatch::Request.new(@env).params
+            # don't initialize params until later otherwise
+            # you get a broken params on the request
+            params = {}
             user_agent  = @env["HTTP_USER_AGENT"]
 
             MobileDetection.resolve_mobile_view!(user_agent,params,session) ? :true : :false