FIX: add excerpt fallback for chat message replies (#26834)

discourse · May 1, 2024 · c1f6ec5 · c1f6ec5 · discoursebot · May 1, 2024
1 parent acdaa3b
commit c1f6ec5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/plugins/chat/app/serializers/chat/in_reply_to_serializer.rb b/plugins/chat/app/serializers/chat/in_reply_to_serializer.rb
@@ -10,5 +10,9 @@ class InReplyToSerializer < ApplicationSerializer
     def user
       object.user || Chat::NullUser.new
     end
+
+    def excerpt
+      object.excerpt || object.build_excerpt
+    end
   end
 end
diff --git a/plugins/chat/spec/serializer/chat/in_reply_to_serializer_spec.rb b/plugins/chat/spec/serializer/chat/in_reply_to_serializer_spec.rb
@@ -30,5 +30,10 @@
     it "censors words" do
       expect(serializer.as_json[:excerpt]).to eq("ok ■■■■■")
     end
+
+    it "builds an excerpt for replied to message if it doesn’t have one" do
+      message.update!(excerpt: nil)
+      expect(serializer.as_json[:excerpt]).to eq(message.build_excerpt)
+    end
   end
 end