FEATURE: Onebox and Download for WEBP and AVIF (#23235)

This adds support for oneboxing WEBP and AVIF images in posts and fixing oneboxing fixes download remote images for those formats too. Reported in https://meta.discourse.org/t/-/276433?u=falco
discourse · Aug 24, 2023 · d10e9a6 · d10e9a6
1 parent 59569a6
commit d10e9a6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/onebox/engine/image_onebox.rb b/lib/onebox/engine/image_onebox.rb
@@ -5,8 +5,8 @@ module Engine
     class ImageOnebox
       include Engine
 
-      matches_content_type(%r{^image/(png|jpg|jpeg|gif|bmp|tif|tiff)$})
-      matches_regexp(%r{^(https?:)?//.+\.(png|jpg|jpeg|gif|bmp|tif|tiff)(\?.*)?$}i)
+      matches_content_type(%r{^image/(png|jpg|jpeg|gif|bmp|tif|tiff|webp|avif)$})
+      matches_regexp(%r{^(https?:)?//.+\.(png|jpg|jpeg|gif|bmp|tif|tiff|webp|avif)(\?.*)?$}i)
 
       def always_https?
         AllowlistedGenericOnebox.host_matches(uri, AllowlistedGenericOnebox.https_hosts)

diff --git a/spec/lib/onebox/engine/image_onebox_spec.rb b/spec/lib/onebox/engine/image_onebox_spec.rb
@@ -39,6 +39,18 @@
     ).to match(/<img/)
   end
 
+  it "supports webp" do
+    expect(Onebox.preview("https://www.gstatic.com/webp/gallery/1.sm.webp").to_s).to match(/<img/)
+  end
+
+  it "supports avif" do
+    expect(
+      Onebox.preview(
+        "https://raw.githubusercontent.com/AOMediaCodec/av1-avif/master/testFiles/Xiph/abandoned_filmgrain.avif",
+      ).to_s,
+    ).to match(/<img/)
+  end
+
   it "supports image URLs with query parameters" do
     expect(
       Onebox.preview(