DEV: Use rubocop-discourse gem to add custom chdir cop

Followup to b27e009
discourse · Nov 18, 2019 · eaf6096 · eaf6096 · discoursereviewbot · Nov 22, 2019
1 parent 6f9afde
commit eaf6096
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 34 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,3 +1,6 @@
+require:
+  - rubocop-discourse
+
 AllCops:
   TargetRubyVersion: 2.4
   DisabledByDefault: true
@@ -128,3 +131,8 @@ Style/Semicolon:
 
 Style/RedundantReturn:
   Enabled: true
+
+DiscourseCops/NoChdir:	
+  Enabled: true	
+  Exclude:	
+    - 'spec/**/*' # Specs are run sequentially, so chdir can be used	
diff --git a/Gemfile b/Gemfile
@@ -143,6 +143,7 @@ group :test, :development do
   gem 'pry-nav'
   gem 'byebug', require: ENV['RM_INFO'].nil?
   gem 'rubocop', require: false
+  gem "rubocop-discourse", require: false
   gem 'parallel_tests'
 end
 

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -348,6 +348,8 @@ GEM
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 1.7)
+    rubocop-discourse (1.0.1)
+      rubocop (>= 0.69.0)
     ruby-openid (2.7.0)
     ruby-prof (0.17.0)
     ruby-progressbar (1.10.0)
@@ -524,6 +526,7 @@ DEPENDENCIES
   rspec-rails (= 4.0.0.beta2)
   rtlit
   rubocop
+  rubocop-discourse
   ruby-prof
   ruby-readability
   rubyzip

diff --git a/lib/rubocop/cop/discourse_cops.rb b/lib/rubocop/cop/discourse_cops.rb