Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SECURITY: Ensure _forum_session cookies cannot be reused between sites (
#14950) This only affects multisite Discourse instances (where multiple forums are served from a single application server). The vast majority of self-hosted Discourse forums do not fall into this category. On affected instances, this vulnerability could allow encrypted session cookies to be re-used between sites served by the same application instance.
- Loading branch information
1 parent
5c43b8a
commit f458536
Showing
2 changed files
with
26 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'rails_helper' | ||
|
||
describe 'multisite', type: [:multisite, :request] do | ||
it "works" do | ||
get "http://test.localhost/session/csrf.json" | ||
expect(response.status).to eq(200) | ||
cookie = response.cookies["_forum_session"] | ||
id1 = session["session_id"] | ||
|
||
get "http://test.localhost/session/csrf.json", headers: { "Cookie" => "_forum_session=#{cookie};" } | ||
expect(response.status).to eq(200) | ||
id2 = session["session_id"] | ||
|
||
expect(id1).to eq(id2) | ||
|
||
get "http://test2.localhost/session/csrf.json", headers: { "Cookie" => "_forum_session=#{cookie};" } | ||
expect(response.status).to eq(200) | ||
id3 = session["session_id"] | ||
|
||
# Session cookie was rejected and rotated | ||
expect(id2).not_to eq(id3) | ||
end | ||
end |