FIX: Do not update last seen notification ID when forced to enable 2F…

…A." (#7222)
discourse · Mar 21, 2019 · fdd2e7f · fdd2e7f
1 parent f7b156f
commit fdd2e7f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/app/assets/javascripts/discourse/widgets/user-notifications.js.es6 b/app/assets/javascripts/discourse/widgets/user-notifications.js.es6
@@ -34,9 +34,10 @@ export default createWidget("user-notifications", {
       limit = 40;
     }
 
+    const silent = this.currentUser.get("enforcedSecondFactor");
     const stale = this.store.findStale(
       "notification",
-      { recent: true, limit },
+      { recent: true, silent, limit },
       { cacheKey: "recent-notifications" }
     );
 
@@ -59,7 +60,9 @@ export default createWidget("user-notifications", {
     stale
       .refresh()
       .then(notifications => {
-        this.currentUser.set("unread_notifications", 0);
+        if (!silent) {
+          this.currentUser.set("unread_notifications", 0);
+        }
         state.notifications = notifications;
       })
       .catch(() => {

diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
@@ -803,7 +803,7 @@ en:
         label: "Code"
         rate_limit: "Please wait before trying another authentication code."
         enable_description: |
-          Scan this QR code in a supported app (<a href="https://www.google.com/search?q=authenticator+apps+for+android" target="_blank">Android</a> – <a href="https://www.google.com/search?q=authenticator+apps+for+ios" target="_blank">iOS</a> and enter your authentication code.
+          Scan this QR code in a supported app (<a href="https://www.google.com/search?q=authenticator+apps+for+android" target="_blank">Android</a> – <a href="https://www.google.com/search?q=authenticator+apps+for+ios" target="_blank">iOS</a>) and enter your authentication code.
         disable_description: "Please enter the authentication code from your app"
         show_key_description: "Enter manually"
         extended_description: |