UX: Style video elements, show descriptions #10040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviltrout
approved these changes
Jun 16, 2020
CvX
added a commit
that referenced
this pull request
Jul 17, 2020
This reverts commit 7d289a4. Now that 36bad0c is in, and we have video previews on all platforms, the commit that's being reverted is no longer needed. In worst case scenario the video description is clipped under the video poster, if the video aspect ratio is other than 16:9. This commit removes descriptions and the custom style for the video elements. # Conflicts: # app/assets/javascripts/pretty-text/addon/engines/discourse-markdown-it.js # test/javascripts/lib/pretty-text-test.js
CvX
added a commit
that referenced
this pull request
Jul 17, 2020
This reverts commit 7d289a4. Now that 36bad0c is in and we have video previews on all platforms, the commit that's being reverted is no longer needed. In the worst case scenario, the video description is clipped under the video poster if the video aspect ratio is other than 16:9. This commit removes descriptions and the custom style for the video elements. # Conflicts: # app/assets/javascripts/pretty-text/addon/engines/discourse-markdown-it.js # test/javascripts/lib/pretty-text-test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a stop gap – ideally we would generate a thumbnail for uploaded videos. For now, a bit of intentionality in the style and a pinch of context should do:
Before/after