FIX: limit number of users addable to group at once #10510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When someone wants to add > 1000 users at once they will hit a timeout. Therefore, we should introduce limit and inform the user when limit is exceeded.
lis2
force-pushed
the
add-group-members-limit
branch
from
f3b6e23
to
6bd92a5
Compare
tgxworld
reviewed
Aug 24, 2020
eviltrout
reviewed
Aug 25, 2020
| @@ -36,6 +36,7 @@ class GroupsController < ApplicationController | |||
| groups.where(automatic: true) | |||
| } | |||
| } | |||
| ADD_MEMBERS_LIMIT = 1000 | |||
There was a problem hiding this comment.
To prevent warnings when reloading it's recommended to use the ||= operator here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone wants to add > 1000 users at once they will hit a timeout.
Therefore, we should introduce limit and inform the user when limit is exceeded.