REFACTOR: Remove .erb file from javascript tests
#10873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use erb in Ember CLI (since it does not have Ruby) so this has been ported to use our `javascript:update_constants` rake test instead. Note we don't have to run this every time a notification type as it's only used by fixtures to fill in some specific types we test against.
jbrw
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use erb in Ember CLI (since it does not have Ruby) so this has
been ported to use our
javascript:update_constantsrake test instead.Note we don't have to run this every time a notification type as it's
only used by fixtures to fill in some specific types we test against.