FEATURE: Mailing list mode default disabled

[jomaxro]

Mailing list mode can generate significant email volume, especially on sites with a large userbase. Disable mailing list mode via site settings by default so sites don't experience an unexpectedly large cost from outgoing email.

[justindirose]

Question here - would changing a default change the setting value on existing sites? I'm going to guess no, but I can't recall off the top of my head.

Otherwise, it's a reasonable change.

[jomaxro]

Yes, it will change the setting for sites that haven't modified it. This will have the effect of disabling mailing list mode on many sites, will make an announcement on Meta about this once merged.

[discoursereviewbot]

Justin DiRose posted:

Wouldn't we want to preserve this functionality though? We might want to consider a way to preserve current site settings as this might be an unexpected breaking change.

[eviltrout]

Code is fine, I'll leave it to you to sort out the other details :)

[discoursereviewbot]

Justin DiRose posted:

I was missing context for the reason we were making this change.

https://meta.discourse.org/t/how-to-make-sure-all-emails-are-off-unless-used-for-activation-or-password-reset/161251/

If we're doing this right before a beta bump as Sam mentioned, I'd say that's reasonable.