REFACTOR: Convert buttons to flexbox #11785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts all our buttons to flexbox, which generally makes them easier to style and align.
It also converts button padding to ems so they scale proportionately with font size changes, and also adds a little additional vertical padding (part of a longer-term effort to use a consistent margin/padding scale).
There are some font-related alignment issues with these buttons in Firefox. Firefox renders fonts differently than Chrome/Safari, so Helvetica sits higher. In a future commit I'll switch to Arial by default, which is consistent across browsers.
Before:
After:
