FIX: Select earliest post when aggregating posts in a topic for search. #11914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a revert of discourse@d8c796b and discourse@5bf0a08. Linking to the post within a topic that has the highest rank was confusing users and hard to explain because ranking is determined via the PG ranking function. See the following meta topics for the complaints after we switch to the new ordering: 1. https://meta.discourse.org/t/title-search-not-working-as-expected/157737 2. https://meta.discourse.org/t/search-results-should-prioritize-first-post-in-topic-when-title-matches-search-term/175154
tgxworld
force-pushed
the
revert_search_behavior
branch
from
da2b464
to
6bb51ed
Compare
tgxworld
commented
Feb 1, 2021
| Search.advanced_order(:chars) do |posts| | ||
| posts.reorder("(SELECT LENGTH(raw) FROM posts WHERE posts.topic_id = subquery.topic_id) DESC") |
There was a problem hiding this comment.
@lis2 Which plugin was using this advanced order? I need to fix that plugin as the query will break.
There was a problem hiding this comment.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
SamSaffron
approved these changes
Feb 3, 2021
lis2
reviewed
Feb 3, 2021
| "MAX(subquery.created_at) created_at" | ||
| ) | ||
| .order("created_at DESC") | ||
| posts = posts.order("MAX(posts.created_at) DESC") |
There was a problem hiding this comment.
Why is that MAX function used here?
There was a problem hiding this comment.
If we're doing aggregation with group, we need to use an aggregation function in the ordering as well. In this case, the latest post in the topic is returned.
lis2
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revert of
d8c796b
and
5bf0a08.
Linking to the post within a topic that has the highest rank was
confusing users and hard to explain because ranking is determined via
the PG ranking function. See the following meta topics for the
complaints after we switch to the new ordering: