DEV: refactor font sizing into css custom variables #12746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/cleaning-up-our-font-system/75396/30 |
CvX
approved these changes
Apr 19, 2021
pmusaraj
approved these changes
Apr 19, 2021
| $base-font-family: var(--font-family) !default; | ||
| $base-font-size-smallest: var(--base-font-size-smallest) !default; | ||
| $base-font-size-smaller: var(--base-font-size-smaller) !default; | ||
| $base-font-size: var(--base-font-size) !default; |
There was a problem hiding this comment.
I'm assuming the SCSS vars are now legacy, the goal is to start using the CSS vars in stylesheets directly, right?
There was a problem hiding this comment.
Yep, we can indeed start moving those over 👍
There was a problem hiding this comment.
One thing to note, we might be carrying those variables for a while yet since we allow those variables to be used in themes and stylesheets, which is unfortunate but we can at least start renaming core vars!
featheredtoast
force-pushed
the
font-sizing-css-custom-vars
branch
from
9cc513a
to
c39fe64
Compare
pmusaraj
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor font sizing variables into CSS custom vars.
Allows any stylesheet to re-use CSS custom variables, regardless of how it's imported or compiled.