Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: removes legacy Ember.keys usage causing a crash #13085

Merged
merged 1 commit into from May 18, 2021
Merged

FIX: removes legacy Ember.keys usage causing a crash #13085

merged 1 commit into from May 18, 2021

Conversation

jjaffeux
Copy link
Contributor

The crash:

Uncaught TypeError: Ember.keys is not a function

Repro:

  • visit home page
  • click new topic
  • navigate to your messages by clicking your avatar (top right), then enveloppe icon, and finally the bottom chevron
  • click New Message
  • click cancel in the composer, it should crash

@jjaffeux
FIX: removes legacy Ember.keys usage causing a crash
83dc2dc 
The crash:

```
Uncaught TypeError: Ember.keys is not a function
```

Repro:

- visit home page
- click new topic
- navigate to your messages by clicking your avatar (top right), then enveloppe icon, and finally the bottom chevron
- click New Message
- click cancel in the composer, it should crash
@jjaffeux jjaffeux requested a review from eviltrout May 18, 2021 08:53
@jjaffeux jjaffeux merged commit c78f32a into discourse:master May 18, 2021
@jjaffeux jjaffeux deleted the ember-keys branch May 18, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX approved these changes

@eviltrout eviltrout Awaiting requested review from eviltrout

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@jjaffeux @CvX