FIX: don't allow category and tag tracking settings on staged users #13688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuring staged users to watch categories and tags is a way to sign them up to get many emails. These emails may be unwanted and get marked as spam, hurting the site's email deliverability. Users can opt-in to email notifications by logging on to their account and configuring their own preferences. If staff need to be able to configure these preferences on behalf of staged users, the "allow changing staged user tracking" site setting can be enabled. Default is to not allow it.
tgxworld
reviewed
Jul 14, 2021
| @@ -30,6 +30,7 @@ def staff_attributes(*attrs) | |||
| can_change_bio | |||
| can_change_location | |||
| can_change_website | |||
| can_change_tracking_preferences | |||
There was a problem hiding this comment.
I don't think we should include this in the user web hook yet as this is doesn't really provide any benefit for the webhook.
There was a problem hiding this comment.
Actually this code was removing it from the serializer. It is excluding attrs from the base serializer. I'll put it back.
tgxworld
reviewed
Jul 14, 2021
tgxworld
reviewed
Jul 14, 2021
tgxworld
reviewed
Jul 14, 2021
tgxworld
reviewed
Jul 14, 2021
tgxworld
reviewed
Jul 14, 2021
tgxworld
reviewed
Jul 14, 2021
tgxworld
reviewed
Jul 14, 2021
tgxworld
reviewed
Jul 14, 2021
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
eviltrout
approved these changes
Jul 16, 2021
| canChangeCategoryPreferences: readOnly( | ||
| "model.can_change_tracking_preferences" | ||
| ), | ||
| canChangeTagPreferences: and( |
There was a problem hiding this comment.
Minor but if you are only using this in a template you can use the (and helper now which will eliminate some code.
There was a problem hiding this comment.
I was aware that was possible, but couldn't find an example of it. TIL it's (and.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring staged users to watch categories and tags is a way to sign
them up to get many emails. These emails may be unwanted and get marked
as spam, hurting the site's email deliverability.
Users can opt-in to email notifications by logging on to their
account and configuring their own preferences.
If staff need to be able to configure these preferences on behalf of
staged users, the "allow changing staged user tracking" site setting
can be enabled. Default is to not allow it.