FIX: Clear stale status of reloaded reviewables #13750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigating away from and back to the reviewables reloaded Reviewable records, but did not clear the "stale" attribute.
When a user acts on a reviewable, all other clients are notified and a generic "reviewable was resolved by someone" notice was shown instead of the buttons. There is no need to keep secret the username of the acting user.
eviltrout
approved these changes
Jul 15, 2021
| @@ -39,6 +39,10 @@ export default DiscourseRoute.extend({ | |||
| sort_order: meta.sort_order, | |||
| additionalFilters: meta.additional_filters || {}, | |||
| }); | |||
|
|
|||
| controller.reviewables.forEach((reviewable) => { | |||
There was a problem hiding this comment.
Suggestion: controller.reviewables.setEach("stale", false) is a little simpler.
ZogStriP
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigating away from and back to the reviewables reloaded Reviewable
records, but did not clear the "stale" attribute.