UX: New text and style for dominating topic message #13789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awesomerobot
changed the title
jjaffeux
reviewed
Jul 20, 2021
jjaffeux
reviewed
Jul 20, 2021
jjaffeux
reviewed
Jul 20, 2021
app/assets/javascripts/discourse/app/templates/composer/dominating-topic.hbs
Show resolved
Hide resolved
jjaffeux
reviewed
Jul 20, 2021
app/assets/javascripts/discourse/app/templates/composer/dominating-topic.hbs
Outdated
Show resolved
Hide resolved
eviltrout
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shortens the text and (hopefully) makes the message sound less patronizing. It also adds an invite button to make including others easier.
I'm also trying some new styling for shorter messages like this... more padding, larger text, shorter box:
I also made a couple small adjustments to this single-tab invite modal (made the title larger and bold when it's not used along with other tabs)