FIX: perform agree_and_keep action only if possible.
#13967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While deleting spammers from flag modal it's trying to perform `agree_and_keep` action where it's not possible (or already performed).
|
We need a test here :) |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/flag-delete-spammer-does-not-work-anymore/192748/10 |
romanrizzi
reviewed
Aug 17, 2021
app/services/user_destroyer.rb
Outdated
| ReviewableFlaggedPost.where(target_created_by: user).find_each do |reviewable| | ||
| reviewable.perform(@actor, :agree_and_keep) | ||
| reviewable.perform(@actor, :agree_and_keep) if reviewable.actions_for(guardian).has?(:agree_and_keep) |
There was a problem hiding this comment.
Could this still fail if @actor doesn't have enough permissions, even if the system user can agree with the flag? Maybe we should check using @guardian instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While deleting spammers from flag modal it's trying to perform
agree_and_keepaction where it's not possible (or already performed).