FEATURE: Publish read topic tracking events for private messages. #14274
Conversation
| @@ -296,8 +298,6 @@ def track_visit!(topic_id, user_id) | |||
| FROM topic_users AS ftu | |||
| WHERE ftu.user_id = :user_id and ftu.topic_id = :topic_id)" | |||
|
|
|||
| INSERT_TOPIC_USER_SQL_STAFF = INSERT_TOPIC_USER_SQL.gsub("highest_post_number", "highest_staff_post_number") | |||
There was a problem hiding this comment.
No longer required because the SQL query doesn't include highest_post_number anymore.
| topic_users.notification_level, tu.notification_level old_level, tu.last_read_post_number | ||
| " | ||
|
|
||
| UPDATE_TOPIC_USER_SQL_STAFF = UPDATE_TOPIC_USER_SQL.gsub("highest_post_number", "highest_staff_post_number") |
There was a problem hiding this comment.
No longer required because the SQL query doesn't include highest_post_number anymore.
| @@ -312,26 +312,22 @@ def update_last_read(user, topic_id, post_number, new_posts_read, msecs, opts = | |||
| threshold: SiteSetting.default_other_auto_track_topics_after_msecs | |||
| } | |||
|
|
|||
| # 86400000 = 1 day | |||
There was a problem hiding this comment.
No idea what this comment is referring to.
There was a problem hiding this comment.
I think it is because there is an msecs argument for this function and there was a bigger comment closer to the top:
f0e942f#diff-94a17ebd5fec7b95f6eb1bb1576a8e15c52f992367c56e94640a8834b31615a9R168-R188
But yeah not really necessary
| @@ -312,26 +312,22 @@ def update_last_read(user, topic_id, post_number, new_posts_read, msecs, opts = | |||
| threshold: SiteSetting.default_other_auto_track_topics_after_msecs | |||
| } | |||
|
|
|||
| # 86400000 = 1 day | |||
There was a problem hiding this comment.
I think it is because there is an msecs argument for this function and there was a bigger comment closer to the top:
f0e942f#diff-94a17ebd5fec7b95f6eb1bb1576a8e15c52f992367c56e94640a8834b31615a9R168-R188
But yeah not really necessary
tgxworld
force-pushed
the
publish_read_pm
branch
from
bf7939a
to
aff3ca8
Compare
tgxworld
force-pushed
the
publish_read_pm
branch
from
aff3ca8
to
bc22155
Compare
|
Thank you for the review @martin-brennan and @lis2 🤗 |
Follow-up to fc1fd1b