Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: Jump to context search when using Ctrl + F #14611

Closed
wants to merge 1 commit into from
Closed

UX: Jump to context search when using Ctrl + F #14611

wants to merge 1 commit into from

Conversation

pmusaraj
Copy link
Contributor

No description provided.

@tgxworld
Copy link
Contributor

The changes look OK to me but I was wondering if it wouldn't be too hard to test the changes here.

@tgxworld tgxworld added the 👍 OP to merge PR author can go ahead and merge! label Oct 15, 2021
@pmusaraj
Copy link
Contributor Author

Closing this for now, we will take a different approach here.

(Testing this is indeed tricky, I tried it, we can't emulate the actual keyboard event due to Mousetrap. We could sorta get there using appEvents, but that only got me so far, the action was triggered but the await step in the test was returning too early, before the changes had taken place in the DOM.)

@pmusaraj pmusaraj closed this Oct 15, 2021
@pmusaraj pmusaraj deleted the prefill-search-topic-context branch October 15, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgxworld tgxworld tgxworld approved these changes

Assignees
No one assigned
Labels
👍 OP to merge PR author can go ahead and merge!
Milestone
No milestone
2 participants
@pmusaraj @tgxworld