DEV: increase lock timeout for multisite migration #14831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SamSaffron
commented
Nov 7, 2021
SamSaffron
commented
- Increase lock timeout - given multisites may take a while to migrate
- Ensure we do not check for status while db is migrating
- Increase lock timeout - given multisites may take a while to migrate - Ensure we do not check for status while db is migrating
CvX
approved these changes
Nov 8, 2021
danielwaterworth
approved these changes
Nov 8, 2021
OsamaSayegh
added a commit
that referenced
this pull request
Nov 11, 2021
This reverts commit 337ef60.
OsamaSayegh
added a commit
that referenced
this pull request
Nov 11, 2021
…14883) * Revert "DEV: increase lock timeout for multisite migration (#14831)" This partially reverts commit 337ef60. We need to revert the mutex around `db:status:json` because the mutex is not available unless the rails environment is loaded which the `db:status:json` doesn't load before the mutex. We can't load the environment before entering the mutex because the mutex is meant to prevent other instances of the task from loading a rails environment while the database is migrating. Co-authored-by: David Taylor <david@taylorhq.com> Co-authored-by: David Taylor <david@taylorhq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.