FIX: Disable scroll events while on full screen #14864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Safari/Firefox (macOS), toggling full screen on a video triggers several scroll events, and confuses the post stream. On Safari, this results in scrolling upwards after exiting a fullscreen video. This PR disables scroll calculations while there is a full screen element which seems to partially address the issue.
CvX
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Safari/Firefox (macOS), toggling full screen on a video triggers several scroll events, and confuses the post stream. On Safari, this results in scrolling ~20 posts upwards after exiting a fullscreen video.
This PR disables scroll calculations while there is a full screen element which at least partially addresses the issue.