DEV: lib/user-presence improvements
#15046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove JQuery - Remove legacy `document.webkitHidden` support. None of our currently supported browsers need this - Use `passive` event listeners. These allows the browser to process the events first, before passing control to us - Add a new `unseenTime` parameter. This allows consumers to request a delay before being notified about the browser going into the background - Add a method for removing a callback - Fire the callback when presence changes in either direction. Previously it would only fire when the user becomes present after a period of inactivity. - Ensure callbacks are only called once for each state change. Previously they would be called every 60s, regardless of the value - Listen to the `visibilitychanged` and `focus` events, treating them as equivalent to user action. This will make messagebus re-activate more quickly when switching back to a stale tab - Add test helpers - Delete the unused `discourse/lib/page-visible` module. - Call message-bus's onVisibilityChange API directly, rather than dispatching a fake event on the `document`
eviltrout
reviewed
Nov 22, 2021
eviltrout
reviewed
Nov 23, 2021
| @@ -119,6 +119,10 @@ export function setTestPresence(value) { | |||
| testPresence = value; | |||
| } | |||
|
|
|||
| export function clearPresenceCallbacks() { | |||
| callbacks.splice(0, callbacks.length); | |||
There was a problem hiding this comment.
I've also done callbacks.length = 0 which works too.
eviltrout
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.webkitHiddensupport. None of our currently supported browsers need thispassiveevent listeners. These allows the browser to process the events first, before passing control to usbrowserUnseenTimeparameter. This allows consumers to request a delay before being notified about the browser going into the backgroundvisibilitychangedandfocusevents, treating them as equivalent to user action. This will make messagebus re-activate more quickly when switching back to a stale tabdiscourse/lib/page-visiblemodule.document(I intend to use these new APIs for some PresenceChannel improvements)