Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Re-allow node 17, with a warning #15083

Merged
merged 1 commit into from Nov 24, 2021
Merged

DEV: Re-allow node 17, with a warning #15083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/javascripts/admin/package.json
View file
Open in desktop
Expand Up @@ -46,7 +46,7 @@
"loader.js": "^4.7.0"
},
"engines": {
"node": "12.* || 14.* || 16.*",
"node": "12.* || 14.* || >= 16",
"npm": "please-use-yarn",
"yarn": ">= 1.21.1"
},
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/discourse-common/package.json
View file
Open in desktop
Expand Up @@ -46,7 +46,7 @@
"loader.js": "^4.7.0"
},
"engines": {
"node": "12.* || 14.* || 16.*",
"node": "12.* || 14.* || >= 16",
"npm": "please-use-yarn",
"yarn": ">= 1.21.1"
},
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/discourse-hbr/package.json
View file
Open in desktop
Expand Up @@ -46,7 +46,7 @@
"loader.js": "^4.7.0"
},
"engines": {
"node": "12.* || 14.* || 16.*",
"node": "12.* || 14.* || >= 16",
"npm": "please-use-yarn",
"yarn": ">= 1.21.1"
},
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/discourse-widget-hbs/package.json
View file
Open in desktop
Expand Up @@ -46,7 +46,7 @@
"loader.js": "^4.7.0"
},
"engines": {
"node": "12.* || 14.* || 16.*",
"node": "12.* || 14.* || >= 16",
"npm": "please-use-yarn",
"yarn": ">= 1.21.1"
},
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/discourse/lib/bootstrap-json/package.json
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
]
},
"engines": {
"node": "12.* || 14.* || 16.*",
"node": "12.* || 14.* || >= 16",
"npm": "please-use-yarn",
"yarn": ">= 1.21.1"
}
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/discourse/package.json
View file
Open in desktop
Expand Up @@ -66,7 +66,7 @@
"virtual-dom": "^2.1.1"
},
"engines": {
"node": "12.* || 14.* || 16.*",
"node": "12.* || 14.* || >= 16",
"npm": "please-use-yarn",
"yarn": ">= 1.21.1"
},
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/pretty-text/package.json
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@
"loader.js": "^4.7.0"
},
"engines": {
"node": "12.* || 14.* || 16.*",
"node": "12.* || 14.* || >= 16",
"npm": "please-use-yarn",
"yarn": ">= 1.21.1"
},
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/select-kit/package.json
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@
"loader.js": "^4.7.0"
},
"engines": {
"node": "12.* || 14.* || 16.*",
"node": "12.* || 14.* || >= 16",
"npm": "please-use-yarn",
"yarn": ">= 1.21.1"
},
Expand Down
2 changes: 1 addition & 1 deletion app/assets/javascripts/truth-helpers/package.json
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@
"loader.js": "^4.7.0"
},
"engines": {
"node": "12.* || 14.* || 16.*",
"node": "12.* || 14.* || >= 16",
"npm": "please-use-yarn",
"yarn": ">= 1.21.1"
},
Expand Down
10 changes: 10 additions & 0 deletions bin/ember-cli
View file
Open in desktop
Expand Up @@ -26,6 +26,10 @@ class String
def cyan
"\e[36m#{self}\e[0m"
end

def red
"\033[31m#{self}\e[0m"
end
end

if ARGV.include?("-h") || ARGV.include?("--help")
Expand All @@ -48,6 +52,12 @@ end

exit 1 if !system "yarn -s install --cwd #{yarn_dir}"

if !system("node -p 'require(\"crypto\").createHash(\"md4\")'", out: "/dev/null", err: "/dev/null")
$stderr << "#{"ERROR".red}: Node 17 with OpenSSL 3 is currently unsupported\n"
$stderr << "Please use node LTS (16.x) instead\n"
exit 1
end

if ARGV.include?("-u") || ARGV.include?("--unicorn")
unicorn_env = { "DISCOURSE_PORT" => ENV["DISCOURSE_PORT"] || "4200" }
unicorn_pid = spawn(unicorn_env, __dir__ + "/unicorn")
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -66,7 +66,7 @@
"postinstall": "yarn --cwd app/assets/javascripts/discourse"
},
"engines": {
"node": "12.* || 14.* || 16.*",
"node": "12.* || 14.* || >= 16",
"npm": "please-use-yarn",
"yarn": ">= 1.21.1"
}
Expand Down