UX: Maximize the preview space in composer #15188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
# Conflicts: # app/assets/stylesheets/mobile/compose.scss
awesomerobot
approved these changes
Dec 4, 2021
pmusaraj
reviewed
Dec 6, 2021
There was a problem hiding this comment.
I pulled the branch locally and we now have some inconsistencies (not necessarily all due to this PR, specifically).
Composer input and dropdown border colors don't match border colors elsewhere:
Focused border size is 1px for input/dropdown, 2px for textarea:
I think we should stay consistent here, I am struggling to see the justification for why we want to introduce a different aesthetic to only the inputs/dropdowns in the composer.
eviltrout
approved these changes
Dec 6, 2021
|
I restored original input border colors and fixed focus border on the title input. I tried it out with the following:
|
pmusaraj
approved these changes
Dec 6, 2021
# Conflicts: # app/assets/javascripts/discourse/app/templates/composer.hbs
pmusaraj
reviewed
Dec 21, 2021
pmusaraj
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #15117 and #15141. Applies the previous changes to PM-specific fields, makes the preview area take the all the available height of the composer, and unifies more spacing between composer elements.
Since this PR changes
composer,composer-editorandd-editortemplates, some theme components need to be updated:d-editorcomposer-editor: discourse-googlebooks (not maintained anymore?) and discourse-basic-editorcomposer: discourse-basic-editor and one internalI also have to do a spot check of random (popular) themes to see nothing regressed there.