New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: add bulk-select to mobile topic lists #15386
Conversation
@awesomerobot I'm sorry I let this fall through! Imo it makes sense to do it this way. 👍 In the future we can consider using something like a mix of Ember's {{!-- topic-list.hbs --}}
{{#extend-component "d-navigation"}}
{{d-button …something}}
{{/extend-component}}
…the rest of component But for now this is completely fine. 😃 (to make up for the delay I rebased it to include latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice. It looks good to me, only holding off approval because
- it's a slightly stale branch, we should rebase again and do a quick local test.
- it would be great if we could add a minimal test, would be the same as
topic-bulk-actions-test
but using the mobile layout.
Nice work @awesomerobot!
This is a great change, any chance we can drive this to completion this week? |
8e0fbe1
to
adf1640
Compare
@pmusaraj @SamSaffron should be good to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a few very minor comments. Thanks!
app/assets/javascripts/discourse/app/templates/topic-list-header-column.hbr
Show resolved
Hide resolved
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
This will make bulk-select topic-list actions available on mobile. We were previously hiding bulk select on mobile due to space constraints.
This adds a new nav button:
When the above nav button is clicked, avatars in the topic list are replaced by checkboxes, the bulk select bar sticks on scroll: