FIX: Refresh logic in discovery topic lists #15489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before 6e0e601, the flow looked something like: 1. `discovery/topics` controller (which extends `discovery` controller) `afterRefresh()` calls `.send("loadingComplete")` 2. Bubbles to [`discovery` route](https://github.com/discourse/discourse/blob/554ff07786a81ed55c902c074d5ba787cfda0a3b/app/assets/javascripts/discourse/app/routes/discovery.js#L58) 3. Discovery route calls `controllerFor('discovery').loadingComplete()`. `loading` is set false, and the spinner disappears Now that `discovery/topics` defines `loadingComplete` as an action, the `discovery/topics` controller runs its own `loadingComplete` handler logic in step 1, and the action does not bubble any further. This commit adds action overrides in `discovery/topics`, so that the new actions only apply to the main `discovery` controller. The need for this does suggest some more radical refactoring is required, but these are very critical routes, and we are very close to a major release.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/topic-list-loads-forever-in-some-circumstances/214042/5 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/clicking-on-logo-from-default-page-view-fails-to-load-page/214029/6 |
CvX
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 6e0e601, the flow looked something like:
discovery/topicscontroller (which extendsdiscoverycontroller)afterRefresh()calls.send("loadingComplete")discoveryroutecontrollerFor('discovery').loadingComplete().loadingis set false, and the spinner disappearsNow that
discovery/topicsdefinesloadingCompleteas an action, thediscovery/topicscontroller runs its ownloadingCompletehandler logic in step 1, and the action does not bubble any further.This commit adds action overrides in
discovery/topics, so that the new actions only apply to the maindiscoverycontroller. The need for this does suggest some more radical refactoring is required, but these are very critical routes, and we are very close to a major release.Meta topic: https://meta.discourse.org/t/topic-list-loads-forever-in-some-circumstances/214042