New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Don't show the 'Next Month' option in date pickers at the end of the month #15492
Closed
AndrewPrigorshnev
wants to merge
9
commits into
main
from
feature/dont-show-the-next-month-option-at-the-end-of-the-month
Closed
FEATURE: Don't show the 'Next Month' option in date pickers at the end of the month #15492
AndrewPrigorshnev
wants to merge
9
commits into
main
from
feature/dont-show-the-next-month-option-at-the-end-of-the-month
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the additionalOptionsToShow param
eviltrout
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eviltrout
approved these changes
Jan 10, 2022
…he-end-of-the-month
eviltrout
approved these changes
Jan 28, 2022
After internal discussion, we decided not to hide the Next Month option. I'm closing this. |
AndrewPrigorshnev
deleted the
feature/dont-show-the-next-month-option-at-the-end-of-the-month
branch
February 3, 2022 19:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR affects only date-time pickers on the bookmark modal and the topic timer modal.
At the end of the month, the Monday option and the Next Month option can point to the same day or the Next Month option can even appear before the Monday option (in most cases the order is opposite):
This PR makes the Next Month option disappear if it is in less than 7 days from now (edit: actually Next Month works a bit better with Monday if it disappears when it is in 7 or fewer days from now, I changed it in the last commit).
Also, I did some refactoring in this PR, all steps can be seen in the commit history. The most serious step is 9f1c575. In this commit:
time-shortcut-picker
component. This way we won't need to write this code again and again on every form that needs it.additionalOptionsToShow
setting of thetime-shortcut-picker
component. This setting was confusing. The component had default options to pick and these settings:The last one is very confusing, if the option is default it shouldn't be hidden by default. Also, it's enough to have just
hiddenOptions
andcustomOptions
.