Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: print view always shows 0 votes, hide it #15901

Merged
merged 1 commit into from Mar 8, 2022
Merged

UX: print view always shows 0 votes, hide it #15901

merged 1 commit into from Mar 8, 2022

Conversation

awesomerobot
Copy link
Member

Before:
Screen Shot 2022-02-10 at 10 34 54 PM

After:
Screen Shot 2022-02-10 at 10 34 34 PM

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/pdf-record-of-poll-reports-0-votes/162865/6

@eviltrout
Copy link
Contributor

There's a lot of test failures. Are those related?

@awesomerobot
Copy link
Member Author

they seem unrelated as far as I can tell 🤷‍♂️

pmusaraj
pmusaraj approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to rebase and rerun tests in CI, just to be sure the failures are unrelated.

@SamSaffron
Copy link
Member

rebased and forced update ... hopefully tests look better and we can merge 🎊

@pmusaraj pmusaraj merged commit 28842d2 into main Mar 8, 2022
@pmusaraj pmusaraj deleted the poll-print branch March 8, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmusaraj pmusaraj pmusaraj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@awesomerobot @discoursebot @eviltrout @SamSaffron @pmusaraj