FIX: review queue scrolling is not working after take an action. #16346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`reject` method for `Reviewable` model is returning an array. So if we use `this.set` method to update `reviewables` attribute in controller then it replaces the model with an array of objects wrongly. This is now fixed by using the `setObjects` method of the model.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
CvX
approved these changes
Mar 31, 2022
|
@CvX for that, we should add 10 more reviewable items at least. Since the problem is occurring only when scrolling to the 11th item. I thought we don't need a big change in tests for this small fix. Let me know if you like to add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rejectmethod forReviewablemodel is returning an array. So if we usethis.setmethod to updatereviewablesattribute in controller then it replaces the model with an array of objects wrongly. This is now fixed by using thesetObjectsmethod of the model.