Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: pretty up staff color block margins #17365

Closed
wants to merge 11 commits into from
Closed

UX: pretty up staff color block margins #17365

wants to merge 11 commits into from

Conversation

MarcRez33
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 6, 2022

CLA assistant check
All committers have signed the CLA.

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/staff-color-post-notice-css-improvements/232093/2

@tgxworld
Copy link
Contributor

tgxworld commented Jul 7, 2022

@MarcRez33 Thank you for the contribution. To assist us with the review, can you provide a before/after screenshot related to your change in this PR?

@tgxworld
Copy link
Contributor

tgxworld commented Jul 7, 2022

ping @discourse/designers

@MarcRez33
Copy link
Author

They are on meta: https://meta.discourse.org/t/staff-color-post-notice-css-improvements/232093?u=marcp

Just ignore the rounded borders, that is custom css.

chapoi
chapoi previously approved these changes Jul 7, 2022
@chapoi chapoi dismissed their stale review July 7, 2022 14:16

linting error

@awesomerobot awesomerobot changed the title FIX: pretty up staff color block margins UX: pretty up staff color block margins Jul 7, 2022
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/staff-color-post-notice-css-improvements/232093/5

@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/padding-on-profiles-is-broken/232462/5

@pmusaraj
Copy link
Contributor

@chapoi @awesomerobot can you decide one way or another with this PR, please?

@awesomerobot
Copy link
Member

it doesn't look like the comments on Meta were addressed here @MarcRez33... the left of the post text should be aligned with the left of the username text

This PR:
Screen Shot 2022-10-24 at 2 47 09 PM

Desired:
image

@MarcRez33 MarcRez33 closed this by deleting the head repository Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants