Introduce warning message for Safari 13 and below #18258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discourse will be dropping support for these browsers in early 2023. https://meta.discourse.org/t/224747
CvX
approved these changes
Sep 15, 2022
ZogStriP
approved these changes
Sep 15, 2022
xfalcox
reviewed
Sep 15, 2022
| import { withPluginApi } from "discourse/lib/plugin-api"; | ||
|
|
||
| function setupMessage(api) { | ||
| const isSafari = navigator.vendor === "Apple Computer, Inc."; |
There was a problem hiding this comment.
Can't you use the Safari detection from sniff-capabilities ?
There was a problem hiding this comment.
I tried, but on iOS 12, isSafari is false... so I guess our safari detection is broken for older versions. I started fixing it, but I figured it wasn't worth it since we're dropping support very soon anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discourse will be dropping support for these browsers in early 2023. https://meta.discourse.org/t/224747