Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECURITY: Handle incomplete quote bbcode #18311

Merged
merged 1 commit into from
Sep 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/assets/javascripts/discourse/app/widgets/post-cooked.js
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,9 @@ export default class PostCooked {
const $title = $(".title", $aside);

// If post/topic is not found then display username, skip controls
if (e.classList.contains("quote-post-not-found")) {
return (e.querySelector(".title").innerHTML = e.dataset.username);
if (e.classList.contains("quote-post-not-found") && $title.length) {
e.querySelector(".title").innerHTML = e.dataset.username;
return;
}

// Unless it's a full quote, allow click to expand
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { module, test } from "qunit";
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import { render } from "@ember/test-helpers";
import { query } from "discourse/tests/helpers/qunit-helpers";
import { hbs } from "ember-cli-htmlbars";

module("Integration | Component | Widget | post-cooked", function (hooks) {
setupRenderingTest(hooks);

test("quotes with no username and no valid topic", async function (assert) {
this.set("args", {
cooked: `<aside class=\"quote no-group quote-post-not-found\" data-post=\"1\" data-topic=\"123456\">\n<blockquote>\n<p>abcd</p>\n</blockquote>\n</aside>\n<p>Testing the issue</p>`,
});

await render(
hbs`<MountWidget @widget="post-cooked" @args={{this.args}} />`
);

assert.strictEqual(query("blockquote").innerText, "abcd");
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,19 @@ eviltrout</p>
);
});

test("Incomplete quotes", function (assert) {
assert.cookedOptions(
'[quote=", post: 1"]\na quote\n[/quote]',
{ topicId: 2 },
`<aside class=\"quote no-group\" data-post=\"1\">
<blockquote>
<p>a quote</p>
</blockquote>
</aside>`,
"works with missing username"
);
});

test("Mentions", function (assert) {
assert.cooked(
"Hello @sam",
Expand Down