FIX: Evaluate all callbacks rather than override them #18788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
force-pushed
the
multiple-post-menu-button-callbacks
branch
from
0fd141b
to
1a3166a
Compare
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
CvX
approved these changes
Oct 28, 2022
nattsw
force-pushed
the
multiple-post-menu-button-callbacks
branch
from
1a3166a
to
1edbe26
Compare
nattsw
commented
Oct 28, 2022
|
Will merge on Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have multiple plugins triggering
the last plugin that makes the call gets to decide if the post menu button is removed or not. This change makes it such that we will evaluate all callbacks rather than just rely on the last one.
Essentially, we ended up with duplicate like buttons when the discourse-upvotes plugin evaluates after discourse-reactions.
Related: https://meta.discourse.org/t/thumbs-up-twice/240867/