Add a test for create_post in import scripts #18893
Conversation
|
|
| }.to change{Post.count}.by(1) | ||
| end | ||
|
|
||
| if ENV["IMPORT"] == "1" |
There was a problem hiding this comment.
It's a little unconventional to do conditional testing like this (developers would need to prefix their rspec command with IMPORT=1 to activate these tests) but then it's a little unconventional to do conditional gem includes in Gemfile.
Arguably it would be more flexible if the condition was String.method_defined?(:bbcode_to_md) (Then developers need only have the gem installed. No need to set IMPORT=1). Let me know if you'd prefer that, but I decided it would look even more unclear as to why these tests are only sometimes run. As it stands, the first test here serves to document the unusual conditional Gemfile set-up.
Add some testing of the `create_post` method in ImportScripts::Base Basic test of Post creation and (if enabled) the bbcode_to_md call.
harry-wood
force-pushed
the
add-import-test
branch
from
563dd46
to
b0fe35c
Compare
|
This one is ready for review @gschlager (Putting this test in place is the first step of the bigger WIP PR you were looking at) |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/migration-from-fluxbb-while-preserving-incoming-links/172351/8 |
Add some testing of the
create_postmethod in ImportScripts::BaseBasic test of Post creation and (if enabled) the bbcode_to_md call.