Make topic lists show last activity more intuitively #193
Conversation
|
What is the status of this? To be honest I don't quite follow the initial topic. |
|
Well, it's still an issue in the sense that the behaviour hasn't changed. Editing the last post in a topic causes the topic to be bumped, so the position of the topic in the topics list might seem wrong based on the values shown for last activity. As an example, the original list of topics in the screenshot would have shown last post values similar to
...where the 20h value appears incorrectly sorted to the user. This change just makes it so that the "last post time" column doubles as a "last bump time" column, so that the ordering matches the information shown to the user. |
|
Right now (and for the next 19 hours, I suppose) the post RSS feeds for categories. appears out of order, perhaps because of this: |
|
Oh I understand now, thanks. Here's a question: why can't we just display bumped_at there? I see you have logic to take the max of the post date and bumped_at -- is there a situation where bumped_at is not present? I'd rather fix it there and simplify client logic by always displaying bumped_at. Thoughts? |
|
I'm not sure, I realised after the fact that taking the max there may not have been necessary, but I forgot to go back and check. I'll take a look when I get home today and tidy things up as appropriate. As far as the client logic goes, I'm not sure what the best approach is – I think there's some benefit in differentiating between an edit bump and a new response bump, which is what most of the conditionals in the template are doing. |
|
Any updates on this one? |
|
Whoops, kind of dropped the ball on this one. I believe I got distracted when looking at this the other day, so I'll finish up and give you an update once I get back from the office later today. |
|
we needs to decide this one ... don't want it to hang in the PR list forever :) |
|
Yes let us just display bumped at date here, I don't like the two date solution. |
|
Hmm, the problem is that if we don't differentiate between them, the value in that column becomes ambiguous @coding-horror . Should we keep a single date and still visually differentiate between them, or just swap last post for last bump? Admittedly I'm not 100% on why editing the last post is considered bump worthy, but I assumed there was a specific reason when I did this. |
|
I would just swap the dates rather than adding a bunch of extra stuff or words to the page. It's not that hard to figure out, look at the post, see the pencil icon next to it, note that the date is the same... |
|
You're the boss! Commit amended and rebased. |
|
personally I am ok with this, I tire of this PR sitting in the queue, @eviltrout @coding-horror ? |
|
I'm cool with it. If @coding-horror says so let's merge. |
|
Sure lets do it On Wednesday, March 27, 2013 at 8:59 AM, Robin Ward wrote:
|
Make topic lists show last activity more intuitively
Apparently editing the most recent (and only the most recent) post in a topic causes the topic to be bumped, which can be confusing since the displayed date on the topic list is the last post date.
I tweaked things a little so the last activity date will be displayed as the
bumped_atage when appropriate, and the tooltip will contain both pieces of information. The last post date is now also shown when the topic is bumped even when there are no replies (i.e. the topic post itself was edited).I tried to avoid confusion by reducing the opacity when the value for the second column is due to the bump instead of to a new reply being posted by lowering the opacity, like in the following screenshot:
I'm not positive this is the best solution, but unless bumping on edit is dropped completely the current behaviour seems more confusing.