FIX: Disable clientside image optimization in iOS Safari #19790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are various performance issues with the Canvas in iOS Safari that are causing crashes when processing images with spikes of over 100% CPU usage. The cause of this is unknown, but profiling points to CanvasRenderingContext2D.getImageData() and CanvasRenderingContext2D.drawImage(). Until Safari makes some progress with OffscreenCanvas or other alternatives we cannot support this workflow. We will revisit in 6 months. This is gated behind the hidden `composer_ios_media_optimisation_image_enabled` site setting for people who really still want to try using this.
martin-brennan
changed the title
martin-brennan
changed the title
nattsw
approved these changes
Jan 9, 2023
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/client-side-image-optimization-enabled-by-default/197617/3 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various performance issues with the Canvas in iOS Safari
that are causing crashes when processing images with spikes of over 100%
CPU usage. The cause of this is unknown, but profiling points to
CanvasRenderingContext2D.getImageData() and
CanvasRenderingContext2D.drawImage().
Until Safari makes some progress with OffscreenCanvas or other
alternatives we cannot support this workflow. We will revisit in 6
months.
This is gated behind the hidden
composer_ios_media_optimisation_image_enabledsite setting for people who really still want to try using this.