FIX: text selection breaks opening of links in new tabs #19867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user checks "Open all external links in a new tab" preference he expects not to be overruled by unrelated text selections. Yet if text is selected during a link click the link is followed on the same tab. This change corrects that.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
|
I tried it locally and looks good to me, thanks 👍 |
jjaffeux
approved these changes
Jan 24, 2023
nattsw
pushed a commit
that referenced
this pull request
Jan 25, 2023
When a user checks "Open all external links in a new tab" preference he expects not to be overruled by unrelated text selections. Yet if text is selected during a link click the link is followed on the same tab. This change corrects that.
nbianca
pushed a commit
that referenced
this pull request
Jan 25, 2023
When a user checks "Open all external links in a new tab" preference he expects not to be overruled by unrelated text selections. Yet if text is selected during a link click the link is followed on the same tab. This change corrects that.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user checks "Open all external links in a new tab" preference he expects not to be overruled by unrelated text selections. Yet if text is selected during a link click the link is followed on the same tab. This change corrects that.