Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: phpBB3 importer: quote attribution #20646

Merged
merged 1 commit into from Apr 5, 2023

Conversation

ftc2
Copy link
Contributor

@ftc2 ftc2 commented Mar 11, 2023

for proper quotes (those including a valid reference to a source post), the importer failed to yield a username, and the imported quote was broken.

for proper quotes (those including a valid reference to a source post), the
importer failed to yield a username, and the imported quote was broken.
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/migrate-a-phpbb3-forum-to-discourse/30810/747

@CvX CvX requested a review from gschlager March 22, 2023 13:14
Copy link
Member

@gschlager gschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@gschlager gschlager merged commit ad32fa5 into discourse:main Apr 5, 2023
10 of 11 checks passed
ChadBoschert pushed a commit to apt-crowd/discourse that referenced this pull request Apr 26, 2023
for proper quotes (those including a valid reference to a source post), the
importer failed to yield a username, and the imported quote was broken.
enduvar pushed a commit to ForgottenWorld/discourse that referenced this pull request Sep 8, 2023
for proper quotes (those including a valid reference to a source post), the
importer failed to yield a username, and the imported quote was broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants