FIX: Better detect text selection in search input #21202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to 17ba00c. Fix for https://meta.discourse.org/t/-/261917 This fixes a usability issue where the user couldn't switch to the user menu when the search menu was visible and the text in the input was selected. Explanation: The `click` event is triggered both when clicking and when selecting some text and clicking. This means that when selecting text in the search input, at the end of the selection event, a click event was triggered. And if that click event happened to be outside of the search menu, then the menu would be dismissed. Previously, we fixed this by checked if a current text selection was present. But that results in a small side-effect of not switching to other menus. This PR switches to setting a flag during `mouseDown` and then using that flag when evaluating whether to trigger clickOutside or not.
davidtaylorhq
approved these changes
Apr 21, 2023
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
ChadBoschert
pushed a commit
to apt-crowd/discourse
that referenced
this pull request
Apr 26, 2023
Followup to 17ba00c. Fix for https://meta.discourse.org/t/-/261917 This fixes a usability issue where the user couldn't switch to the user menu when the search menu was visible and the text in the input was selected. Explanation: The `click` event is triggered both when clicking and when selecting some text and clicking. This means that when selecting text in the search input, at the end of the selection event, a click event was triggered. And if that click event happened to be outside of the search menu, then the menu would be dismissed. Previously, we fixed this by checked if a current text selection was present. But that results in a small side-effect of not switching to other menus. This PR switches to setting a flag during `mouseDown` and then using that flag when evaluating whether to trigger clickOutside or not.
enduvar
pushed a commit
to ForgottenWorld/discourse
that referenced
this pull request
Sep 8, 2023
Followup to 17ba00c. Fix for https://meta.discourse.org/t/-/261917 This fixes a usability issue where the user couldn't switch to the user menu when the search menu was visible and the text in the input was selected. Explanation: The `click` event is triggered both when clicking and when selecting some text and clicking. This means that when selecting text in the search input, at the end of the selection event, a click event was triggered. And if that click event happened to be outside of the search menu, then the menu would be dismissed. Previously, we fixed this by checked if a current text selection was present. But that results in a small side-effect of not switching to other menus. This PR switches to setting a flag during `mouseDown` and then using that flag when evaluating whether to trigger clickOutside or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to 17ba00c. Fix for https://meta.discourse.org/t/-/261917
This fixes a usability issue where the user couldn't switch to the user menu when the search menu was visible and the text in the input was selected.
Explanation: The
clickevent is triggered both when clicking and when selecting text. This means that when selecting text in the search input, at the end of the selection event, a click event is triggered. And if that click event happens outside of the search menu (i.e. when you continue dragging outside the input), then the menu would be dismissed.Previously, we fixed this by checked for the presence of a current text selection. But that results in a small side-effect reported in the linked issue on meta. This PR sets a flag during
mouseDownwhen starting a text selection in the input and then it uses that flag when evaluating whether to triggerclickOutsideor not.