FIX: do not allow title stuffing to dominate search #21464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were giving topics with repeated words extra weight in search index. This meant that it was trivial to stuff words into title to dominate in search given we search for exact title matches first. The following tweak means that: `invite invited invites` and `invite some stuff` Both rank the same for title searching. Titles are short and punchy, duplicating words should not give special weight. Requires a full reindex to take effect.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/making-documentation-more-prominent-in-search/263206/10 |
oblakeerickson
approved these changes
May 10, 2023
enduvar
pushed a commit
to ForgottenWorld/discourse
that referenced
this pull request
Sep 8, 2023
We were giving topics with repeated words extra weight in search index. This meant that it was trivial to stuff words into title to dominate in search given we search for exact title matches first. The following tweak means that: `invite invited invites` and `invite some stuff` Both rank the same for title searching. Titles are short and punchy, duplicating words should not give special weight. Requires a full reindex to take effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were giving topics with repeated words extra weight in search index.
This meant that it was trivial to stuff words into title to dominate in search
given we search for exact title matches first.
The following tweak means that:
invite invited invitesand
invite some stuffBoth rank the same for title searching.
Titles are short and punchy, duplicating words should not give special
weight.
Requires a full reindex to take effect.