Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Refresh site when enable_user_tips changes #21489

Merged
merged 2 commits into from May 12, 2023
Merged

FIX: Refresh site when enable_user_tips changes #21489

merged 2 commits into from May 12, 2023

Conversation

nbianca
Copy link
Member

@nbianca nbianca commented May 10, 2023

Without refresh, no user tip will be shown and Site.user_tips is not
properly populated either.

The other commit fixes the MessageBus handler until page is refreshed.

Without refresh, no user tip will be shown and Site.user_tips is not
properly populated either.
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/message-bus-fail-when-changing-skip-new-user-onboarding-tips-and-badges-user-setting/264019/4

@nbianca nbianca merged commit b32cdb0 into main May 12, 2023
12 of 13 checks passed
@nbianca nbianca deleted the fix_user_tips branch May 12, 2023 15:44
martin-brennan pushed a commit that referenced this pull request May 16, 2023
Without refresh, no user tip will be shown and Site.user_tips is not
properly populated either.
enduvar pushed a commit to ForgottenWorld/discourse that referenced this pull request Sep 8, 2023
Without refresh, no user tip will be shown and Site.user_tips is not
properly populated either.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants