Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Separated 'trusted users can edit others' setting for trust level 3 & 4 #21493

Merged
merged 12 commits into from Jul 7, 2023
Merged

FEATURE: Separated 'trusted users can edit others' setting for trust level 3 & 4 #21493

merged 12 commits into from Jul 7, 2023

Conversation

rngus2344
Copy link
Contributor

@rngus2344 rngus2344 marked this pull request as draft May 10, 2023 20:22
@rngus2344 rngus2344 marked this pull request as ready for review May 11, 2023 17:50
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/separate-trusted-users-can-edit-others-setting-for-trust-levels-3-4/257312/12

nattsw
nattsw requested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@nattsw nattsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally very good except that the tests and descriptions need to cover the new settings properly.

nattsw
nattsw requested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@nattsw nattsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally very good except that the tests and descriptions need to cover the new settings properly.

@markvanlan markvanlan mentioned this pull request Jul 3, 2023
Merged
@nattsw
Copy link
Contributor

nattsw commented Jul 7, 2023

Sorry it's taken a while!

@markvanlan markvanlan merged commit b70bd43 into discourse:main Jul 7, 2023
13 checks passed
@markvanlan markvanlan deleted the new_discourse_branch branch July 7, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamSaffron SamSaffron SamSaffron left review comments

@markvanlan markvanlan markvanlan left review comments

@nattsw nattsw nattsw approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@rngus2344 @discoursebot @nattsw @SamSaffron @markvanlan